Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SID Visualization Example #354

Merged
4 commits merged into from
Sep 16, 2022
Merged

SID Visualization Example #354

4 commits merged into from
Sep 16, 2022

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Sep 14, 2022 •
edited by mdemoret-nv
Loading

  • Clean up SID visualization example
  • Add Morpheus visualization repo as submodule
  • Document SID visualization example

Closes #347
Closes #348
Closes #349
Closes #205

@efajardo-nv efajardo-nv added non-breaking Non-breaking change doc Improvements or additions to documentation feature request New feature or request labels Sep 14, 2022
@efajardo-nv efajardo-nv added this to the Visualization Repository milestone Sep 14, 2022
@efajardo-nv efajardo-nv removed the doc Improvements or additions to documentation label Sep 14, 2022
@efajardo-nv efajardo-nv changed the title SID Visualization SID Visualization Example Sep 14, 2022
@efajardo-nv
Copy link
Contributor Author

rerun tests

1 similar comment
@efajardo-nv
Copy link
Contributor Author

rerun tests

@efajardo-nv efajardo-nv marked this pull request as ready for review September 14, 2022 20:01
@efajardo-nv efajardo-nv requested review from a team as code owners September 14, 2022 20:01
mdemoret-nv
mdemoret-nv requested changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few changes. The pictures look good.

examples/sid_visualization/commands.sh Outdated Show resolved Hide resolved
examples/sid_visualization/README.md Show resolved Hide resolved
examples/sid_visualization/README.md Show resolved Hide resolved
morpheus/pipeline/stage.py Outdated Show resolved Hide resolved
morpheus/stages/postprocess/generate_viz_frames_stage.py Outdated Show resolved Hide resolved
morpheus/stages/postprocess/generate_viz_frames_stage.py Outdated Show resolved Hide resolved
morpheus/utils/file_utils.py Outdated Show resolved Hide resolved
@BartleyR
Copy link
Contributor

I will test this

@mdemoret-nv mdemoret-nv requested a review from a team as a code owner September 15, 2022 19:10
BartleyR
BartleyR requested changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@BartleyR BartleyR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is good, it's easy to follow and seems correct. I could use a bit more detail on the specific versions, and it would be ideal if we could make some things more explicit (details in the review).

examples/sid_visualization/README.md Outdated Show resolved Hide resolved
examples/sid_visualization/README.md Outdated Show resolved Hide resolved
examples/sid_visualization/README.md Show resolved Hide resolved
examples/sid_visualization/README.md Outdated Show resolved Hide resolved
examples/sid_visualization/README.md Show resolved Hide resolved
examples/sid_visualization/README.md Outdated Show resolved Hide resolved
examples/sid_visualization/README.md Show resolved Hide resolved
@efajardo-nv
Copy link
Contributor Author

rerun tests

1 similar comment
@efajardo-nv
Copy link
Contributor Author

rerun tests

mdemoret-nv
mdemoret-nv approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BartleyR BartleyR self-requested a review September 16, 2022 21:40
@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit ddc0d23 into nv-morpheus:branch-22.09 Sep 16, 2022
@efajardo-nv efajardo-nv deleted the sid-viz-update branch July 29, 2024 21:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BartleyR BartleyR BartleyR approved these changes

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
Visualization Repository
3 participants
@efajardo-nv @BartleyR @mdemoret-nv